add minification step at prepublishOnly and test-ci #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same version of node passes the same tests here as used by the failing CI tests. I'm not sure what causes this. |
|
I think the echo command is breaking the encoding |
|
I made a serious error storing the values in the variable first. I didn't find the esbuild option to allow over-writing to the source file so was trying to work around that. Fortunately, the ci tests are updated to test the minified sources and will catch this error if it happens in the future. iambumblehead/resolvewithplus#17 |
> npx esbuild ./src/*[mj]s --minify --allow-overwrite --outdir=src/
src/esmockModule.js 2.6kb
src/esmockLoader.js 1.4kb
src/esmock.ode.js 743b
src/esmock.js 731b
src/esmockCache.js 427b
src/esmockIsLoader.js 184b
⚡ Done in 3msthis command works nicely, should work in windows and has a nice little summary |
|
I couldn't find a way to make esbuild process a set of files in windows. The minify commands here aren't nice but maybe they could be replaced later on. |
iambumblehead
force-pushed
the
add-minifer-step
branch
from
31863c6 to
f3b715f
Compare
|
closes #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Swivelgames if you are available and would review this, please review
I tried two different esbuild minifier commands, because the main "--minifier" command broke esmock and caused the tests to fail.
esbuild $filename --minify,esbuild $filename --minify-whitespace --minify-identifiers