prioritize import specigier over packagejson exported type #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koshic
reviewed
Jan 24, 2025
| @@ -318,7 +318,9 @@ const esmparse = (spec, specifier, opts = {}) => { | |||
| // if dynamic 'spectype', lookup 'commonjs' or 'module' | |||
| // according to package.json | |||
| specname = specname === spectype | |||
| ? getspectypenamedexportdefault(opts.packagejsontype) | |||
| ? isDirPathRe.test(specifier) | |||
There was a problem hiding this comment.
the whole logic looks a bit... suspicious for me - it's a kind of mix of 'how to resolve exact import' (exports field logic) and 'how to detect module type - CJS or ESM' (type field). but, if it works - let's merge
koshic
approved these changes
Jan 24, 2025
|
"specifier" here is basically a path such as opanai/path.js "path.js", a subpath such as opanai#subpath or a keyword-specifier such as "import" or "node" https://github.com/iambumblehead/resolvewithplus/blob/main/resolvewithplus.js#L517 pspecifier ? './' + pspecifier : specimport |
|
esm is ... very difficult |
iambumblehead
deleted the
prioritize-import-specifier-over-packagejson-exported-type
branch
|
Thx for explanation - now that code looks clear. BTW, ESM and resolution logic... they are simple, BUT if you can image the whole possible scenarios at once :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iambumblehead/esmock#321