Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isToday, isTomorrow, isYesterday #299

Closed
epszaw opened this issue Aug 13, 2018 · 8 comments · Fixed by #857
Closed

isToday, isTomorrow, isYesterday #299

epszaw opened this issue Aug 13, 2018 · 8 comments · Fixed by #857
Labels
released

Comments

@epszaw
Copy link

epszaw commented Aug 13, 2018 •
edited by iamkun
Loading

Update:

https://day.js.org/docs/en/plugin/is-today
https://day.js.org/docs/en/plugin/is-tomorrow
https://day.js.org/docs/en/plugin/is-yesterday

Hello, @iamkun!
What do you think about that helpers? I think it can be really usefull in some cases.
For exmple – you need to know, is it date is today and you simplify call dayjs(date).isToday().
@epszaw
Copy link
Author

epszaw commented Aug 13, 2018

Also, I can try to implement that functional in plugin 😉

@jelaxshan
Copy link

Will this be implemented soon?

@epszaw
Copy link
Author

epszaw commented Sep 4, 2018

@jelaxshan I will try it on this week.

epszaw pushed a commit to epszaw/dayjs that referenced this issue Sep 10, 2018
Add relative date helpers (iamkun#299)
e33cbf0
@iamkun
Copy link
Owner

iamkun commented Feb 2, 2019 •
edited
Loading

Update:

https://day.js.org/docs/en/plugin/is-today
https://day.js.org/docs/en/plugin/is-tomorrow
https://day.js.org/docs/en/plugin/is-yesterday

I'll close this issue since it's been a while since it's been opened. Feel free to reopen if you have updates on this

@iamkun iamkun closed this as completed Feb 2, 2019
@cwilby
Copy link

cwilby commented Apr 3, 2020

@lamartire can you create a pull request for epszaw@e33cbf0 ?

@epszaw
Copy link
Author

epszaw commented Apr 7, 2020

@cwilby can't locate this at this moment. I can try to do that again, looks like not a big problem

epszaw pushed a commit to epszaw/dayjs that referenced this issue Apr 7, 2020
Add relative date helpers (iamkun#299)
76e5592
epszaw pushed a commit to epszaw/dayjs that referenced this issue Apr 7, 2020
Add relative date helpers (iamkun#299)
c5fb0a1
@epszaw epszaw mentioned this issue Apr 7, 2020
Merged
@epszaw
Copy link
Author

epszaw commented Apr 7, 2020

@cwilby, so, I have reopened that PR - #857

epszaw pushed a commit to epszaw/dayjs that referenced this issue Apr 7, 2020
Add relative date helpers (iamkun#299)
dc7782e
epszaw pushed a commit to epszaw/dayjs that referenced this issue Apr 7, 2020
feat: add relative date helpers plugins (iamkun#299)
77e1f30
@iamkun
Copy link
Owner

iamkun commented Apr 10, 2020

🎉 This issue has been resolved in version 1.8.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

isToday, isTomorrow, isYesterday plugins epszaw/dayjs
4 participants
@epszaw @cwilby @iamkun @jelaxshan