-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation for Indonesian languange #193
Conversation
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 16 +1
Lines 308 311 +3
Branches 52 52
=====================================
+ Hits 308 311 +3
Continue to review full report at Codecov.
|
Thanks @muhibbudins . However, I think, |
Urwell @iamkun , Yups, but i don't know why on my VSCode and Terminal they ignore every |
src/locale/id.js
Outdated
Q: 'kuartal', | ||
Y: 'tahun', | ||
DATE: 'tanggal', | ||
weekdays: 'Minggu_Senin_Selasa_Rabu_Kamis_Jum\'at_Sabtu'.split('_'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be Jumat ? I don't know, just feel weird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm okey i'll fix it
Besides, I'm going to merge pr#189, and there's a little change in our locale file. You could check the PS, this might could not pass our current test, but don't worry, after merge it will be fine |
Great THX |
Urwell @iamkun |
🎉 This PR is included in version 1.6.4 🎉@muhibbudins |
Hi @iamkun,
I try to add translation for Indonesian Language with key name id, and then i add some condition at .gitignore file like this :
To ignore only locale/ folder not src/locale/.
Thank you