add spanish documentation & extra locale #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 42 43 +1
Lines 422 425 +3
Branches 55 55
=====================================
+ Hits 422 425 +3
Continue to review full report at Codecov.
|
|
Great, thanks. |
|
I'll merge this PR first. If there is any updates or grammar corrections, feel free to send new PR. |
|
🎉 This PR is included in version 1.7.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I cloned
src/locale/es.jsintosrc/locale/es-es.js,similarly to how was done with
ptandpt-br.The reason is obvious: so many Spanish dialects. Leaving it with only
eswould be problematic, especially when someone from anotherSpanish-speaking country come to suggest editions because of this
Spanish not being the Spanish he is used to (understandable). And this is, as far as I can see,
already done and accepted with, at least,
pt, so I think thiswill be OK. Tell me if not and I will edit it
(remove it
/src/locale/es-es, docs better have that way, so much text, couldbe so different between countries) but have in mind the previous reasoning ^^.