-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin advancedCompare #404
Add plugin advancedCompare #404
Conversation
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 46 48 +2
Lines 434 437 +3
Branches 55 58 +3
=====================================
+ Hits 434 437 +3
Continue to review full report at Codecov.
|
such a hot topic for me, is this going to be merged and released soon? |
Please provide me with some feedback on the status of this PR. Is there anything missing from my side? Is there any behind-the-scenes quality assurance going on? Are you awaiting community feedback? Are you just busy with other work? I tried to resolve all conversation as fast as possible, not it got stalled for a week for no reason obvious to me, so please give me a quick hint of how it's going to proceed. Thanks! |
Thanks. There's a little problem with our npm account. And I'll merge this into next release after I get the account fixed. |
Alright, thanks for the update. Can you make any projection on how long that might take? Is it days, weeks or months? |
Not sure, but as soon as possible. |
🎉 This PR is included in version 1.7.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
great |
Thanks a lot, great support and discussion with all of you! |
We switched from moment.js to dayjs on a project that made heavy use of moment.js, especially comparisons considering units as well. Thought I'll share this a plugin. All tests taken from moment.js and adjusted to run with the dayjs test suite.