Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin advancedCompare #404

Merged
merged 12 commits into from
Dec 11, 2018

Conversation

suspectpart
Copy link
Contributor

We switched from moment.js to dayjs on a project that made heavy use of moment.js, especially comparisons considering units as well. Thought I'll share this a plugin. All tests taken from moment.js and adjusted to run with the dayjs test suite.

@codecov-io
Copy link

codecov-io commented Nov 6, 2018

Codecov Report

Merging #404 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #404   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          46     48    +2     
  Lines         434    437    +3     
  Branches       55     58    +3     
=====================================
+ Hits          434    437    +3
Impacted Files Coverage Δ
src/plugin/isBetween/index.js 100% <100%> (ø) ⬆️
src/plugin/isSameOrBefore/index.js 100% <100%> (ø)
src/index.js 100% <100%> (ø) ⬆️
src/plugin/isSameOrAfter/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ae06b...83f9d25. Read the comment docs.

@Liooo
Copy link
Contributor

Liooo commented Nov 8, 2018

such a hot topic for me, is this going to be merged and released soon?

index.d.ts Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@suspectpart
Copy link
Contributor Author

@xxyuk @iamkun Can we merge this soon? It just got outdated with master (again). What is the status on your side?

@suspectpart
Copy link
Contributor Author

@xxyuk @iamkun Can we merge this soon? It just got outdated with master (again). What is the status on your side?

Please provide me with some feedback on the status of this PR. Is there anything missing from my side? Is there any behind-the-scenes quality assurance going on? Are you awaiting community feedback? Are you just busy with other work? I tried to resolve all conversation as fast as possible, not it got stalled for a week for no reason obvious to me, so please give me a quick hint of how it's going to proceed. Thanks!

@iamkun
Copy link
Owner

iamkun commented Nov 20, 2018

Thanks. There's a little problem with our npm account. And I'll merge this into next release after I get the account fixed.

@suspectpart
Copy link
Contributor Author

Thanks. There's a little problem with our npm account. And I'll merge this into next release after I get the account fixed.

Alright, thanks for the update. Can you make any projection on how long that might take? Is it days, weeks or months?

@iamkun
Copy link
Owner

iamkun commented Nov 21, 2018

Not sure, but as soon as possible.

@iamkun iamkun merged commit 616bf1a into iamkun:master Dec 11, 2018
@iamkun
Copy link
Owner

iamkun commented Dec 13, 2018

🎉 This PR is included in version 1.7.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost
Copy link

ghost commented Dec 14, 2018

great

@suspectpart
Copy link
Contributor Author

Thanks a lot, great support and discussion with all of you!

@suspectpart suspectpart deleted the feat/plugin-advanced-compare branch February 12, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants