Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slate-react text render still get error in ie11 #3013

Closed
ThomasChan opened this issue Sep 10, 2019 · 3 comments
Closed

slate-react text render still get error in ie11 #3013

ThomasChan opened this issue Sep 10, 2019 · 3 comments

Comments

@ThomasChan
Copy link

Do you want to request a feature or report a bug?

Report bug

What's the current behavior?

slate-react/src/components/text.js#L18 the leaves is generated from node.getLeaves function, and slate/src/models/text.js#L152 getLeaves function finally returned a immutable List, that's a Object, so ie11 still get error Objects are not valid as a React child

What's the expected behavior?

Modify slate-react text render function, make leaves toArray.

Should i make a pr?

ThomasChan added a commit to henglabs/slate that referenced this issue Sep 10, 2019
@mmdonaldson
Copy link
Contributor

Can you reproduce in a codepen or jsfiddle?

@ThomasChan
Copy link
Author

@mmdonaldson unfortunately both codepen and jsfiddle do not support ie11, i can't provide online demo too, but i got my production's error screenshot in ie11 if you want see.

屏幕快照 2019-09-17 下午9 36 40

And i'm 100% sure that error was throw by text.js#L152 which mentioned above, then i use my commit to webpack build, that error is gone.

@ianstormtaylor ianstormtaylor mentioned this issue Nov 6, 2019
@ianstormtaylor
Copy link
Owner

As of #3093 (which was just merged), I believe this issue is no longer applicable, because a lot has changed. I'm going through and closing out any potential issues that are not out of date with the overhaul. Thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants