-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slate-react text render still get error in ie11 #3013
Comments
Can you reproduce in a codepen or jsfiddle? |
@mmdonaldson unfortunately both codepen and jsfiddle do not support ie11, i can't provide online demo too, but i got my production's error screenshot in ie11 if you want see. And i'm 100% sure that error was throw by text.js#L152 which mentioned above, then i use my commit to webpack build, that error is gone. |
As of #3093 (which was just merged), I believe this issue is no longer applicable, because a lot has changed. I'm going through and closing out any potential issues that are not out of date with the overhaul. Thanks for understanding. |
Do you want to request a feature or report a bug?
Report bug
What's the current behavior?
slate-react/src/components/text.js#L18
theleaves
is generated fromnode.getLeaves
function, andslate/src/models/text.js#L152
getLeaves
function finally returned a immutable List, that's aObject
, so ie11 still get errorObjects are not valid as a React child
What's the expected behavior?
Modify slate-react text render function, make leaves toArray.
Should i make a pr?
The text was updated successfully, but these errors were encountered: