Remove is native #1088
Merged
Remove is native #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Looked over it and nothing is glaring, this is going to do amazing things for the complexity of this part of the codebase though 🥂 |
This was referenced Sep 30, 2017
rgrove
added a commit
to rgrove/slate
that referenced
this pull request
Oct 4, 2017
Preventing native text input events completely breaks autocorrect, autocomplete, auto-capitalization, predictive text, and double-space period insertion on iOS. In order to allow iOS to perform these kinds of operations, we have to avoid preventing the default event behavior and allow native input handling whenever possible. Fixes ianstormtaylor#1176 Fixes ianstormtaylor#1177 See also: ianstormtaylor#1088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @conorcussell for kicking this off in #964!
If anyone can test this branch to double-check my work, that would be super appreciated!
This removes the
isNativeflag from Slate, with seemingly zero performance reprecutions! 🎉 Instead of spending a significant amount of time calculating things inonBeforeInput, it now spends an equivalent-ish amount of time inrenderandupdateSelection. Previously these two were being skipped for "native" updates.As far as I can tell the performance benefits from
isNativeare negligible with all of the other performance handling logic we have (memoizing method,shouldComponentUpdateshortcuts, etc.) so we can remove it. Which seems nice, because it is a cause for lots of headaches UX-wise.I won't merge this for a little bit, because I want to give the recent
0.22a chance to settle and for plugins to get updated first before doing another breaking change. (Even though it is way less breaking.)Fixes #963