Include current node in iterator of node.getClosest

[Dundercover]

Is this adding or improving a feature or fixing a bug?

Improving a feature

What's the new behavior?

Node methods getClosest, getClosestBlock, getClosestInline and getClosestVoid will now return the current node if it is a match (so it matches the behaviour of the DOM's native Element.closest().

How does this change work?

Add the current node to the list of nodes that will be iterated over in node.getClosest.

Also added some tests for node.getClosest.

Have you checked that...?

• The new code matches the existing patterns and styles.
• The tests pass with yarn test.
• The linter passes with yarn lint. (Fix errors with yarn prettier.)
• The relevant examples still work. (Run examples with yarn watch.)

Does this fix any issues or need any specific reviewers?

Fixes: #2111

[Dundercover]

By the way! Shouldn't getFurthest methods now also include current node?

[ianstormtaylor]

Hey @Dundercover this looks good! Thank so very much for taking the time to do this. I think you're right about furthest—as long as that's what the DOM does, not sure. Would you be willing to add that to this PR?

I'm going to mark this with a new next label since it's breaking, as something to merge in the next breaking change. Thanks!

[ianstormtaylor]

Why write these like this with the object spreading? Instead of just writing className=? Even better might be to use thing="value" or something more abstract just to avoid confusion with DOM stuff.

[ianstormtaylor]

Also no need to include key= on all elements here. We only need it on the specific node we're targeting in the test itself. That way we reduce maintenance burden.

[Dundercover]

Sounds good!

[Dundercover]

@ianstormtaylor I'm actually not aware of a furthest method in DOM land, do you know what you would use for that?

[ianstormtaylor]

Ah, I didn't realize there wasn't one. I'd use the same logic—including ancestors and the node itself. And then just search top-down instead of bottom-up.

[ianstormtaylor]

Fixed by #3093.