move_node tests and code clean up #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jtadmor
commented
Jan 22, 2019
| @@ -1763,13 +1763,12 @@ class ElementInterface { | |||
| const newParentPath = PathUtils.lift(newPath) | |||
| this.assertNode(newParentPath) | |||
|
|
|||
| const [p, np] = PathUtils.crop(path, newPath) | |||
| const position = PathUtils.compare(p, np) | |||
There was a problem hiding this comment.
Minor issue, but we don't really need p and np since compare only checks the smaller size anyway. This avoids the two calls to .slice that crop makes. We just use path.size in the conditional below because we know it is smaller than newPath in order to hit that line
jtadmor
commented
Jan 22, 2019
| .slice(0, newPathLast) | ||
| .concat(inverseNewPath.get(newPathLast) + 1) | ||
| .concat(inverseNewPath.slice(newPathLast + 1, inverseNewPath.size)) | ||
| if (path.size < newPath.size && position === -1) { |
There was a problem hiding this comment.
Use the same style as the check in element. Some new tests were added to make sure this all still works.
jtadmor
changed the title
moveNodeByPath tests and code clean up
jtadmor
force-pushed
the
improvement/2192
branch
from
966c36a to
8e37ec3
Compare
jtadmor
force-pushed
the
improvement/2192
branch
from
8e37ec3 to
26a4fd0
Compare
|
@jtadmor this is absolutely beautiful, thank you very much! My favorite type of pull request 😄 |
davidnus
pushed a commit
to davidnus/slate
that referenced
this pull request
Feb 11, 2019
* tests * refactor moveNodeByPath * refactor element.move_node * refactor invert.move_node
z2devil
pushed a commit
to z2devil/slate
that referenced
this pull request
Dec 6, 2024
* tests * refactor moveNodeByPath * refactor element.move_node * refactor invert.move_node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this adding or improving a feature or fixing a bug?
Improvement (mostly adding tests, some refactoring).
Mostly, this work / investigation was done to satisfy: #2192 (which appears to no longer be necessary, unless I misunderstood)
That issue was cited as a blocker for: #2225
This should also clear up: #2328
What's the new behavior?
n/a
How does this change work?
invert.move_nodewas substantially simplified usingPathUtils, bringing the code more in line withelement.moveNodeCommands.moveNodeByPathfunction arguments were renamed (internal) to clarify their purpose.Have you checked that...?
yarn test.yarn lint. (Fix errors withyarn prettier.)yarn watch.)Does this fix any issues or need any specific reviewers?
Fixes: #2192, #2328
Reviewers: @