Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify semantics of return from deserialize #2665

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

tslocke
Copy link
Contributor

@tslocke tslocke commented Mar 26, 2019

This can trip folks up who are using compile-to-JS languages (ClojureScript in my case), where return semantics may be different.

Is this adding or improving a feature or fixing a bug?

What's the new behavior?

How does this change work?

Have you checked that...?

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn prettier.)
  • The relevant examples still work. (Run examples with yarn watch.)

Does this fix any issues or need any specific reviewers?

Fixes: #
Reviewers: @

This can trip folks up who are using compile-to-JS languages (ClojureScript in my case), where return semantics may be different.
@ianstormtaylor
Copy link
Owner

Thanks @tslocke!

(I agree this is not the least confusing API. Maybe we’ll find a better solution in the future.)

@ianstormtaylor ianstormtaylor merged commit 2380aa0 into ianstormtaylor:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants