Fix composition input on Safari (native InputEvents) #2743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix/accents round2
This reverts commit 3124bbb.
|
Is there any news on when this will be merged? @ianstormtaylor? |
chore: Add codeowners
|
I'm not sure about how this works. IME support has been a long-running issue, and something that seems fairly complex, so I'm unsure if this handles the cases properly. Check the existing issues we've got going to see prior discussions. |
4 tasks
|
@ianstormtaylor I have a more complete description of the issue in my PR #3040. That said I think the approach taken in this PR is also valid, and even addresses an issue that mine does not (canceling IME input should leave it in the composition text in place). |
Closed
|
Fixed by #3093. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this adding or improving a feature or fixing a bug?
Bug fix
What's the new behavior?
Composition events are now handled on native InputEvents
How does this change work?
It would allow accented characters (i.e à, ò, ï, â, etc)
Have you checked that...?
yarn test.yarn lint. (Fix errors withyarn prettier.)yarn watch.)Does this fix any issues or need any specific reviewers?
Fixes: #2499