Fix deleting backwards when there are only inlines #2850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…letes all inlines)
Tetramputechture
suggested changes
Jun 17, 2019
| // If the next sibling is an inline, has no text and the focus offset is 0, | ||
| // then delete the inline | ||
| if ( | ||
| traversed === 0 && |
There was a problem hiding this comment.
would you want to refactor this compound conditional to its own method? something like 'shouldDeleteInline'
Closed
|
Fixed by #3093. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #2621.
The bug happens when there are no text nodes between the cursor and the start of the document.
Is this adding or improving a feature or fixing a bug?
Fixing a bug
What's the new behavior?
Deletes an inline without erroring.
How does this change work?
If the previous node is an Inline, the focus offset is 0 and the text value of the inline is empty, then the inline is deleted.
Have you checked that...?
yarn test.yarn lint. (Fix errors withyarn prettier.)yarn watch.)Does this fix any issues or need any specific reviewers?
Fixes: #2621