Simplify logic of selection extend forward. #2931
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There is a problem with "code highlighting" example - extending selection forward has no effect when we reach a zero-width span with "".
To reproduce:
I do not understand why slate has different logic for handling the selection between "rightarrow" and "shift+rightarrow" cases, but simplyfing the later seems to help.
Can you please have a look at this, whether the logic can be removed, or there is a case for it ?
Thanks in advance!