Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logic of selection extend forward. #2931

Conversation

themithy
Copy link
Contributor

Hi,

There is a problem with "code highlighting" example - extending selection forward has no effect when we reach a zero-width span with "&#65279".

To reproduce:

  1. go to code highlighting example.
  2. put the cursor in the second code line (at offset zero)
  3. Hold shift and press the right arrow several times
  4. At some point the selection stops moving.

I do not understand why slate has different logic for handling the selection between "rightarrow" and "shift+rightarrow" cases, but simplyfing the later seems to help.

Can you please have a look at this, whether the logic can be removed, or there is a case for it ?

Thanks in advance!

@ianstormtaylor ianstormtaylor mentioned this pull request Nov 14, 2019
@ianstormtaylor
Copy link
Owner

Fixed by #3093.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants