Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix document.getPath with node key as input in findPath util function #3003

Closed
wants to merge 1 commit into from

Conversation

kwokhuen
Copy link

@kwokhuen kwokhuen commented Sep 6, 2019

Is this adding or improving a feature or fixing a bug?

Fixing a bug.

What's the new behavior?

In slate-react/utils, findPath function does not work as expected, as document.getPath function required a node key as input.

How does this change work?

document.getPath should take node key as input.

Have you checked that...?

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn prettier.)
  • The relevant examples still work. (Run examples with yarn watch.)

Does this fix any issues or need any specific reviewers?

Fixes: #
Reviewers: @ianstormtaylor

@kwokhuen kwokhuen force-pushed the fix-utils-find-path branch from 5e98abe to 0d1d637 Compare September 6, 2019 04:53
@ianstormtaylor ianstormtaylor mentioned this pull request Nov 14, 2019
@ianstormtaylor
Copy link
Owner

As of #3093 (which was just merged), I believe this issue is no longer applicable, because a lot has changed. I'm going through and closing out any potential issues that are not out of date with the overhaul. Thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants