Fix soft breaks on android using the diff's cursor #3049
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this adding or improving a feature or fixing a bug?
Fixing a bug
Here's a video before the fix
The soft break is done before the letter.
What's the new behavior?
We use the cursor position from the diff before applying the break.
Here's a video after the fix
How does this change work?
Previously, the editor would save a selection with the wrong offset, and apply that selection before doing the soft break. That would usually apply the soft break before the letter or the word that was entered.
To fix the issue, we accumulate previous adjacent text nodes offset and we also use the diff's cursor to apply the selection before splitting blocks.
Have you checked that...?
yarn test
.yarn lint
. (Fix errors withyarn prettier
.)yarn watch
.)Does this fix any issues or need any specific reviewers?
Fixes: #
Reviewers: @thesunny @ianstormtaylor