Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this adding or improving a feature or fixing a bug?
Fixing a bug
What's the new behavior?
When writing such plugin:
When starting a composition,
"hello"
is printed in the console. This works today on desktop.However, this is not the case for Android. On Android, the Noop plugin was activated, and no hooks would call next.
As stated in
noop.js
:However, it was always activated in
dom/index.js
:How does this change work?
I added a switch to turn on or off the noop plugin and added calls to
next()
in the hooks of the Android pluginHave you checked that...?
yarn test
.yarn lint
. (Fix errors withyarn prettier
.)yarn watch
.)Does this fix any issues or need any specific reviewers?
Fixes: #
Reviewers: @ianstormtaylor