Fix backward typing bug in Safari by ensuring the selection is removed on blur #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d on blur Safari doesn't always remove the selection, even if the contenteditable element no longer has focus. In this scenario, we need to forcefully remove the selection on blur https://stackoverflow.com/questions/12353247/force-contenteditable-div-to-stop-accepting-input-after-it-loses-focus-under-web
🦋 Changeset detectedLatest commit: 5189402 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clauderic
commented
Jun 7, 2021
| @@ -560,8 +560,6 @@ export const Editable = (props: EditableProps) => { | |||
| return | |||
| } | |||
|
|
|||
| const window = ReactEditor.getWindow(editor) | |||
There was a problem hiding this comment.
This line was unused so I took the liberty of deleting it
clauderic
force-pushed
the
fix-safari-backwards-typing
branch
from
69b51d2 to
5189402
Compare
Merged
dylans
pushed a commit
to dylans/slate
that referenced
this pull request
Sep 13, 2021
…d on blur (ianstormtaylor#4324) Safari doesn't always remove the selection, even if the contenteditable element no longer has focus. In this scenario, we need to forcefully remove the selection on blur https://stackoverflow.com/questions/12353247/force-contenteditable-div-to-stop-accepting-input-after-it-loses-focus-under-web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Safari doesn't always remove the selection, even if the contenteditable element no longer has focus. In this scenario, we need to forcefully remove the selection on blur https://stackoverflow.com/questions/12353247/force-contenteditable-div-to-stop-accepting-input-after-it-loses-focus-under-web
Issue
I could not find any open issues related to this specific bug. There are other issues open with regards to backwards typing bugs but they are unrelated.
Example
To replicate, I simply added a button in the toolbar that calls
ReactEditor.blur(editor)when clicked:Safari.backwards.typing.bug.-.Before.mp4
Safari.backwards.typing.bug.-.After.mp4
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)