fix(android): Fix editors mark is not inserted on insert text in android #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8e37979 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
imdbsd
changed the title
|
im testing it on the my android 9 devices and looks fine |
|
issue confirmed on android and can be replicated with the same steps Kapture.2021-07-06.at.10.46.36.mp4 |
|
thanks for the review @dylans |
Merged
Closed
dylans
pushed a commit
to dylans/slate
that referenced
this pull request
Sep 13, 2021
…oid (ianstormtaylor#4342) * fix(android): Fix mark is not inputed on insert text in android * add changeset * null mark only when mark exist Co-authored-by: surya darma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently on rich text example, the mark is not inserted on the inserted text.
step to replicate:
expected: mark should be inserted with the text
Issue
#4405
Example
current example:
fix example:
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)