Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add vscode launch.json debug config #4729

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

ahoisl
Copy link
Contributor

@ahoisl ahoisl commented Dec 10, 2021

Description
Add vscode debug config (launch.json) for Chrome & Firefox.

Context
Needed to easily start/attach a debugger.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2021

🦋 Changeset detected

Latest commit: d108659

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ahoisl
Copy link
Contributor Author

ahoisl commented Dec 10, 2021

Would be great if somebody could verify the config works for them and not just for me, thanks! 😄

@ahoisl ahoisl force-pushed the chore/vscodeLaunch branch from 848fb61 to 435d80f Compare December 17, 2021 09:58
@schnuderl
Copy link

schnuderl commented Dec 17, 2021

looks god. tried a breakpoint in slate and slate-react to try, gets instantly hit withoud need of further configuration. tried it using firefox.

@ahoisl ahoisl force-pushed the chore/vscodeLaunch branch from 435d80f to 2425441 Compare December 17, 2021 10:10
@ahoisl ahoisl force-pushed the chore/vscodeLaunch branch from 2425441 to d108659 Compare December 17, 2021 11:23
@dylans dylans merged commit ab62da2 into ianstormtaylor:main Dec 17, 2021
@github-actions github-actions bot mentioned this pull request Dec 17, 2021
@ahoisl ahoisl deleted the chore/vscodeLaunch branch December 17, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants