Add soft break as a separate overridable editor method #4873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A different behavior for inserting a soft break with
shift+enter
is quite common in rich text editors. Right now you have to do this inonKeyDown
which is not so nice. This adds a separateinsertSoftBreak
method on the editor instance that gets called when a soft break is inserted. I made sure to maintain the current default behavior for backwards compatibility (it just splits the block). But at least you can easily overwrite it now.If you rely on overwriting
editor.insertBreak
for extra behavior for soft breaks this might be a breaking change for you and you should overwriteeditor.insertSoftBreak
instead.Issue
Fixes: (link to issue)
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)