Make onChange prop optional, update examples and docs to treat slate as uncontrolled #4922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the
<Slate/>
onChange
prop optional, updates the docs to treat the<Slate/>
component as uncontrolled to avoid confusion.Context
Ever since #4540 slate is in a weird half state. The API and docs suggest it's controlled as it requires a
onChange
andvalue
prop and all examples keep a record of the state outside the component in auseState
. This causes a lot of confusion, especially for people new to slate (see e.g. #4812) without any good reason.Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)