Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReactEditor.isComposing(editor) #4981

Merged
merged 2 commits into from
May 2, 2022

Conversation

BitPhinix
Copy link
Contributor

Description

Moves the Editable isComposing state into the isComposing WeakMap used by the AndroidEditable and exposes the current state via ReactEditor.isComposing(editor).

It's quite common to handle some events differently inside a user-defined handler based on the isComposing state (e.g. you don't want to trigger markdown shortcuts etc. while the user is composing as that often leads to undesirable behavior).

Currently, you have to keep track of the isComposing state on your own using your own, which I don't think is desirable.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2022

🦋 Changeset detected

Latest commit: 68f28c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit cb8a551 into ianstormtaylor:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants