Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: revert to prior decorations behavior #5007

Conversation

jasonphillips
Copy link
Contributor

Description
This reverts #4876 (and the related #4910 fix to it) while we seek out another way of improving decorations to meet everyone's needs without regressions.

Context
See: #4993

One great addition from #4876 which was not fully reverted here is the creation of tests for slate-react. The specific decorations tests themselves were removed--while the ideal behavior of decorations continues to be revisited in future PRs, and then we can restore them--but the test setup itself was kept, particularly since at least one subsequent PR also uses it.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2022

🦋 Changeset detected

Latest commit: e2e3df8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants