Fix: revert to prior decorations behavior #5007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts #4876 (and the related #4910 fix to it) while we seek out another way of improving decorations to meet everyone's needs without regressions.
Context
See: #4993
One great addition from #4876 which was not fully reverted here is the creation of tests for slate-react. The specific decorations tests themselves were removed--while the ideal behavior of decorations continues to be revisited in future PRs, and then we can restore them--but the test setup itself was kept, particularly since at least one subsequent PR also uses it.
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)