Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to change clipboard fragment format name #5267

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

ilya2204
Copy link
Contributor

@ilya2204 ilya2204 commented Jan 23, 2023

Description
Allow customization of clipboard fragment format name. Based on #5233 and slate-angular

Issue
#5233

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2023

🦋 Changeset detected

Latest commit: 37d6475

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ilya2204 ! Could you please add a changeset and then I'll land this?

@ilya2204
Copy link
Contributor Author

@dylans I added changeset)

@dylans
Copy link
Collaborator

dylans commented Feb 1, 2023

For some reason this is failing our integration tests. I'm going to try to run it again later today.

@ilya2204
Copy link
Contributor Author

ilya2204 commented Feb 9, 2023

@dylans seems to pass all tests

@dylans
Copy link
Collaborator

dylans commented Feb 9, 2023

@ilya2204 yes, we landed a PR a couple of days ago which fixed the failing tests. Thanks for reminding me!

@dylans dylans merged commit 463edbd into ianstormtaylor:main Feb 9, 2023
@github-actions github-actions bot mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants