Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NatGateway to VPC Stack #22

Merged
merged 1 commit into from
Jan 7, 2018
Merged

Add NatGateway to VPC Stack #22

merged 1 commit into from
Jan 7, 2018

Conversation

ibejohn818
Copy link
Owner

  • Add natgateway to vpc
  • Add nat route to private route table
  • Add initial tests

@codecov-io
Copy link

codecov-io commented Jan 7, 2018 •
edited
Loading

Codecov Report

Merging #22 into master will increase coverage by 0.32%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage    48.4%   48.72%   +0.32%     
==========================================
  Files          22       22              
  Lines        1917     1929      +12     
==========================================
+ Hits          928      940      +12     
  Misses        989      989
Impacted Files Coverage Δ
stackformation/cli.py 0% <0%> (ø) ⬆️
stackformation/aws/stacks/vpc.py 96.22% <100%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6e515...340367c. Read the comment docs.

@ibejohn818
Add NatGateway to VPC Stack
340367c 
- Add natgateway to vpc
- Add nat route to private route table
- Add initial tests
@ibejohn818 ibejohn818 merged commit 516e3f1 into master Jan 7, 2018
@ibejohn818 ibejohn818 deleted the nat-gateway branch January 7, 2018 04:41
ibejohn818 added a commit that referenced this pull request Jan 12, 2019
@ibejohn818
Merge pull request #22 from ibejohn818/nat-gateway
589fc0b 
Add NatGateway to VPC Stack
ibejohn818 added a commit that referenced this pull request Jan 12, 2019
@ibejohn818
Merge pull request #22 from ibejohn818/nat-gateway
71a7d29 
Add NatGateway to VPC Stack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibejohn818 @codecov-io