Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved PHPDoc descriptions #1364

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Improved PHPDoc descriptions #1364

merged 2 commits into from
Oct 14, 2024

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Oct 11, 2024

  1. Nad is clearly a typo
  2. Usually we write the policies divided with a slash

These things become visible in the PHP API reference, hence why I'm improving them.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mnocon mnocon requested review from adriendupuis and a team October 11, 2024 09:20
@konradoboza konradoboza requested a review from a team October 14, 2024 06:20
@adamwojs adamwojs merged commit 230a77d into 4.6 Oct 14, 2024
28 checks passed
@adamwojs adamwojs deleted the fix-phpdoc-typo branch October 14, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@adamwojs adamwojs adamwojs approved these changes

@adriendupuis adriendupuis Awaiting requested review from adriendupuis

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mnocon @adamwojs @konradoboza @mikadamczyk @Nattfarinn @ciastektk @ViniTou