IBX-3456 Collapse all button support #1394
Conversation
| @@ -0,0 +1,37 @@ | |||
| .ibexa-multi-collapse { | |||
There was a problem hiding this comment.
Moved styles from product-catalog. Based on previous review comment let me know if I still should change class name to ibexa-pc-...
There was a problem hiding this comment.
if those styles are moved from PC where will be a base twig template for a multi-collapse feature?
There was a problem hiding this comment.
Discussed: There is no base twig template due to its too general purpose
bozatko
force-pushed
the
IBX-3456-attribute-groups
branch
from
c1599eb to
c43983f
Compare
bozatko
force-pushed
the
IBX-3456-attribute-groups
branch
from
1228b09 to
c8db495
Compare
| ? /*@Desc("Collapse all)*/ 'product_type.edit.section.attribute_collapse_all' | ||
| : /*@Desc("Expand all)*/ 'product_type.edit.section.attribute_expand_all'; | ||
|
|
||
| btn.innerText = Translator.trans(displayedText, {}, 'ibexa_product_catalog'); |
There was a problem hiding this comment.
We should not use any product catalog prefixes and translation domain here. Is there any option to pass translated labels into component? This will be more flexible.
There was a problem hiding this comment.
after discussion: created new translation file "ibexa_collapse"
bozatko
force-pushed
the
IBX-3456-attribute-groups
branch
from
baed467 to
349a81f
Compare
...bundle/Resources/views/themes/admin/ui/component/collapse_all_btn/collapse_all_btn.html.twig
Outdated
Show resolved
Hide resolved
|
Related PRs:
Description:
For QA:
Documentation: