IBX-9313: Fix fetching ContentInfo on select #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
commented
Dec 19, 2024
| @@ -244,7 +244,7 @@ const UniversalDiscoveryModule = (props) => { | |||
| .join(','); | |||
|
|
|||
| if (!locationIds) { | |||
| return Promise.resolve([]); | |||
| return Promise.resolve(null); | |||
There was a problem hiding this comment.
Note: changed to null, because when data is present we have an object with data (not an array) so resolving sometimes with an object and sometimes with an empty array was confusing.
dew326
approved these changes
Dec 19, 2024
bozatko
approved these changes
Dec 20, 2024
lucasOsti
approved these changes
Dec 20, 2024
juskora
force-pushed
the
IBX-9313-Version-is-undefined-useAlwaysAvailable
branch
from
bd86837 to
e46f807
Compare
|
|
QA Approved on Ibexa DXP Experience 4.6. |
juskora
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
After this and previous changes (from other PRs) that optimized the UDW request, it would be good to perform a thorough checkup to ensure that everything is working correctly with various language settings like the one described in the JIRA ticket.
Documentation: