Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-9217: Added URL validation #1418

Open
wants to merge 1 commit into
base: 4.6
Choose a base branch
from
Open

Conversation

lucasOsti
Copy link
Contributor

🎫 Issue IBX-9217

Description:

For QA:

Documentation:

@lucasOsti lucasOsti added Bug Something isn't working Ready for review labels Jan 14, 2025
@lucasOsti lucasOsti changed the base branch from main to 4.6 January 14, 2025 09:26
@glye glye self-requested a review January 14, 2025 09:53
Copy link
Contributor

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, this will approve all valid URLs no matter the protocol. If we later want to introduce an FT setting to only allow certain protocols, we can support that here by checking the url protocol property.

@lucasOsti
Copy link
Contributor Author

As I understand it, this will approve all valid URLs no matter the protocol. If we later want to introduce an FT setting to only allow certain protocols, we can support that here by checking the url protocol property.

In this implementation, I’m checking if string is a valid url, no matter what the protocol is, as long as it is actually a protocol :) but we can later add additional protocol validation via property protocol of URL

const parsedUrl = new URL(urlValue); parsedUrl.protocol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants