Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHP 8.0 tests #14

Closed
wants to merge 2 commits into from
Closed

Added PHP 8.0 tests #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c8fe8
Added PHP 8.0 & 8.1 tests
Steveb-p Nov 10, 2021
d15be54
Switched `TestLogger` to `NullLogger`
Steveb-p Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ jobs:
php:
- '7.4'
composer_options: [ "" ]
include:
- php: '8.0'
composer_options: "--ignore-platform-req php"
experimental: true

steps:
- uses: actions/checkout@v2
Expand Down
4 changes: 2 additions & 2 deletions src/contracts/Test/IbexaTestKernel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
use FOS\JsRoutingBundle\FOSJsRoutingBundle;
use JMS\TranslationBundle\JMSTranslationBundle;
use Liip\ImagineBundle\LiipImagineBundle;
use Psr\Log\Test\TestLogger;
use Psr\Log\NullLogger;
use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
use Symfony\Bundle\SecurityBundle\SecurityBundle;
use Symfony\Bundle\TwigBundle\TwigBundle;
Expand Down Expand Up @@ -193,6 +193,6 @@ private static function createPublicAliasesForServicesUnderTest(ContainerBuilder

private static function setUpTestLogger(ContainerBuilder $container): void
{
$container->setDefinition('logger', new Definition(TestLogger::class));
$container->setDefinition('logger', new Definition(NullLogger::class));
}
}