Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-5111: Introduced custom find and result extracting capabilities #239

Closed
wants to merge 1 commit into from

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented May 29, 2023

Question Answer
JIRA issue IBX-5111
Type feature
Target Ibexa version v4.6
BC breaks no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/php-dev).

@konradoboza konradoboza force-pushed the variants_indexing branch 3 times, most recently from 55676c9 to 4c1efd7 Compare June 2, 2023 10:52
@konradoboza konradoboza added the Feature New feature request label Jun 2, 2023
@konradoboza konradoboza self-assigned this Jun 2, 2023
@konradoboza konradoboza force-pushed the variants_indexing branch 2 times, most recently from d0299d8 to e011a31 Compare June 5, 2023 12:19
@konradoboza konradoboza force-pushed the variants_indexing branch 3 times, most recently from 9373d3c to 17988ef Compare June 15, 2023 09:23
@konradoboza konradoboza changed the title IBX-5111: Introduced mapper registry for customizing value object building on search hits IBX-5111: Introduced custom find and result extracting capabilities Jun 15, 2023
Comment on lines +13 to +15
/**
* @param array{}|array{languages: array<string>, useAlwaysAvailable: bool} $languageFilter
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
* @param array{}|array{languages: array<string>, useAlwaysAvailable: bool} $languageFilter
*/
/**
* @param array{languages?: array<string>, useAlwaysAvailable?: bool} $languageFilter
*/

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
3.7% 3.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint


namespace Ibexa\Contracts\Core\Repository\Values\Search;

interface SearchContextInterface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that Context implies that there might be parameters that are outside of our current expectations that are used by third party code. In my opinion it should be flexible enough that any underlying search engine could pick parameters that it is interested in.

@konradoboza konradoboza closed this Jan 8, 2024
@konradoboza konradoboza deleted the variants_indexing branch January 8, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants