-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-1580: External storage for field type settings #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
force-pushed
the
field_settings_external_storage
branch
from
December 4, 2021 11:01
4f961de
to
9d57c7c
Compare
adamwojs
force-pushed
the
field_settings_external_storage
branch
from
December 4, 2021 13:01
7888be9
to
bd2a2a1
Compare
Steveb-p
reviewed
Dec 9, 2021
tests/lib/Persistence/Legacy/Content/Type/ContentTypeHandlerTest.php
Outdated
Show resolved
Hide resolved
tests/lib/Persistence/Legacy/Content/Type/ContentTypeHandlerTest.php
Outdated
Show resolved
Hide resolved
Steveb-p
approved these changes
Dec 9, 2021
alongosz
requested changes
Dec 14, 2021
src/lib/Resources/settings/storage_engines/legacy/content_type.yml
Outdated
Show resolved
Hide resolved
tests/integration/Core/FieldType/FieldConstraintsStorage/Stub/ExampleFieldType.php
Show resolved
Hide resolved
tests/integration/Core/FieldType/FieldConstraintsStorage/Stub/ExampleFieldType.php
Show resolved
Hide resolved
alongosz
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.0
Added extension point which allows o load field type settings from external source.
External storage for Field Type settings needs implement
and be registered as a service with tag
ibexa.field_type.external_constraints_storage
e.g.Checklist:
$ composer fix-cs
).@ibexa/engineering
).