Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated phpstan baseline #310

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Updated phpstan baseline #310

merged 1 commit into from
Dec 13, 2023

Conversation

adamwojs
Copy link
Member

Question Answer
JIRA issue N/A
Type improvement
Target Ibexa version v4.6
BC breaks no

Updated phpstan baseline

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@adamwojs adamwojs requested a review from a team December 13, 2023 15:54
@alongosz alongosz requested a review from a team December 13, 2023 15:55
@adamwojs adamwojs mentioned this pull request Dec 13, 2023
Merged
6 tasks
@alongosz alongosz merged commit 8ee2fb7 into 4.5 Dec 13, 2023
21 checks passed
@alongosz alongosz deleted the fixed_phpstan_issues branch December 13, 2023 16:15
@alongosz
Copy link
Member

Thank you Sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamwojs @alongosz @kisztof @mikadamczyk