Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Composer] Dropped obsolete symfony/thanks config #338

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Feb 19, 2024

Question Answer
JIRA issue n/a
Type improvement
Target Ibexa version v4.6
BC breaks yes (?), but of no value reduced

Long time ago we decided to add config for https://github.com/symfony/thanks. That feature was a Symfony extension point able to add GitHub star to a configured package (which can be done via GitHub interface anyway). At that time there was single ezsystems/ezplatform meta-package, which no longer applies.

We could configure ibexa/oss or ibexa/core itself, but I think it doesn't produce any value for DXP, so I'm proposing to remove it instead.

Checklist:

  • Provided PR description.
  • Checked that target branch is set correctly.
  • Asked for a review.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@alongosz alongosz merged commit 58ffa8c into main Feb 19, 2024
22 checks passed
@alongosz alongosz deleted the drop-composer-thanks branch February 19, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants