Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1853: Rebranded services names #55

Merged
merged 5 commits into from
Jan 20, 2022
Merged

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jan 19, 2022

@ViniTou ViniTou force-pushed the IBX-1853-rebranded-services branch from 747a7da to d8783fd Compare January 19, 2022 14:46
@adamwojs
Copy link
Member

Unit tests are failing here

Comment on lines +3 to +71
ibexa.api.repository:
alias: Ibexa\Core\Repository\SiteAccessAware\Repository
public: true

ezpublish.api.service.bookmark:
ibexa.api.service.bookmark:
alias: Ibexa\Core\Event\BookmarkService
public: true

ezpublish.api.service.content:
ibexa.api.service.content:
alias: Ibexa\Core\Repository\SiteAccessAware\ContentService
public: true

ezpublish.api.service.content_type:
ibexa.api.service.content_type:
alias: Ibexa\Core\Repository\SiteAccessAware\ContentTypeService
public: true

ezpublish.api.service.field_type:
ibexa.api.service.field_type:
alias: Ibexa\Core\Event\FieldTypeService
public: true

ezpublish.api.service.role:
ibexa.api.service.role:
alias: Ibexa\Core\Event\RoleService
public: true

ezpublish.api.service.object_state:
ibexa.api.service.object_state:
alias: Ibexa\Core\Repository\SiteAccessAware\ObjectStateService
public: true

ezpublish.api.service.url_wildcard:
ibexa.api.service.url_wildcard:
alias: Ibexa\Core\Event\URLWildcardService
public: true

ezpublish.api.service.url_alias:
ibexa.api.service.url_alias:
alias: Ibexa\Core\Repository\SiteAccessAware\URLAliasService
public: true

ezpublish.api.service.user:
ibexa.api.service.user:
alias: Ibexa\Core\Repository\SiteAccessAware\UserService
public: true

ezpublish.api.service.search:
ibexa.api.service.search:
alias: Ibexa\Core\Repository\SiteAccessAware\SearchService
public: true

ezpublish.api.service.section:
ibexa.api.service.section:
alias: Ibexa\Core\Repository\SiteAccessAware\SectionService
public: true

ezpublish.api.service.trash:
ibexa.api.service.trash:
alias: Ibexa\Core\Repository\SiteAccessAware\TrashService
public: true

ezpublish.api.service.location:
ibexa.api.service.location:
alias: Ibexa\Core\Repository\SiteAccessAware\LocationService
public: true

ezpublish.api.service.language:
ibexa.api.service.language:
alias: Ibexa\Core\Repository\SiteAccessAware\LanguageService
public: true

ezpublish.api.service.url:
ibexa.api.service.url:
alias: Ibexa\Core\Event\URLService
public: true

ezpublish.api.service.notification:
ibexa.api.service.notification:
alias: Ibexa\Core\Repository\SiteAccessAware\NotificationService
public: true

ezpublish.api.service.user_preference:
ibexa.api.service.user_preference:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I would use here directly interfaces from Ibexa\Contracts\... rather than named services and got rid of aliasing in autowire.yml.

@ViniTou ViniTou merged commit c174136 into main Jan 20, 2022
@ViniTou ViniTou deleted the IBX-1853-rebranded-services branch January 20, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants