[Tests] Improved CustomTagsValidatorTest and RichTextTest code quality

ibexa · Sep 18, 2024 · 5505205 · 5505205
1 parent 7044bbc
commit 5505205
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/tests/bundle/DependencyInjection/Configuration/Parser/FieldType/RichTextTest.php b/tests/bundle/DependencyInjection/Configuration/Parser/FieldType/RichTextTest.php
@@ -69,7 +69,7 @@ protected function configureAndLoad(array $configurationValues = [])
 
             $extensionAlias = $extension->getAlias();
             // when loading extension, pass only relevant configuration
-            $extensionConfig = isset($configs[$extensionAlias]) ? $configs[$extensionAlias] : [];
+            $extensionConfig = $configs[$extensionAlias] ?? [];
 
             $extension->load([$extensionConfig], $this->container);
         }

diff --git a/tests/lib/RichText/Validator/CustomTagsValidatorTest.php b/tests/lib/RichText/Validator/CustomTagsValidatorTest.php
@@ -14,16 +14,11 @@
 use Symfony\Component\Yaml\Yaml;
 
 /**
- * Test RichText CustomTagsValidator.
- *
- * @see \Ibexa\FieldTypeRichText\FieldType\RichText\CustomTagsValidator
+ * @covers \Ibexa\FieldTypeRichText\FieldType\RichText\CustomTagsValidator
  */
-class CustomTagsValidatorTest extends TestCase
+final class CustomTagsValidatorTest extends TestCase
 {
-    /**
-     * @var \Ibexa\FieldTypeRichText\RichText\Validator\CustomTagsValidator
-     */
-    private $validator;
+    private CustomTagsValidator $validator;
 
     public function setUp(): void
     {
@@ -37,8 +32,6 @@ public function setUp(): void
     /**
      * Test validating DocBook document containing Custom Tags.
      *
-     * @covers \Ibexa\FieldTypeRichText\RichText\CustomTagsValidator::validateDocument
-     *
      * @dataProvider providerForTestValidateDocument
      *
      * @param \DOMDocument $document