Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6932: Fixed adding custom attrs to list #139

Merged
merged 4 commits into from
Feb 14, 2024
Merged

IBX-6932: Fixed adding custom attrs to list #139

merged 4 commits into from
Feb 14, 2024

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Dec 20, 2023 •
edited by webhdx
Loading

Question Answer
JIRA issue IBX-6932
Bug/Improvement yes
New feature no
Target version 4.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 self-assigned this Dec 20, 2023
@micszo micszo self-assigned this Jan 3, 2024
@micszo micszo mentioned this pull request Jan 10, 2024
Closed
@micszo
Copy link
Contributor

micszo commented Jan 12, 2024

Discovered issue with listItem losing attributes values which does not occur without this branch.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

micszo
micszo approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 4.5.6-dev.

@micszo micszo removed their assignment Feb 14, 2024
@konradoboza konradoboza merged commit 058d349 into 4.5 Feb 14, 2024
21 checks passed
@konradoboza konradoboza deleted the list-custom-attrs branch February 14, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gengar-i Gengar-i Gengar-i approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@micszo micszo micszo approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees

@alongosz alongosz

@dew326 dew326

@konradoboza konradoboza

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@dew326 @micszo @GrabowskiM @tischsoic @lucasOsti @Gengar-i @alongosz @webhdx @konradoboza @mateuszdebinski