Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7725: RTE area is hidden if custom-tag label is too long #146

Merged
merged 4 commits into from
Mar 4, 2024
Merged

IBX-7725: RTE area is hidden if custom-tag label is too long #146

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a9ca9d
IBX-7725: RTE area is hidden if custom-tag label is too long
vidarl Feb 6, 2024
3e9acd8
fixup! IBX-7725: RTE area is hidden if custom-tag label is too long
vidarl Feb 14, 2024
e88ccf4
IBX-7725: Applied prettier
Gengar-i Feb 23, 2024
daeb05d
Update src/bundle/Resources/public/js/CKEditor/custom-tags/block-cust…
vidarl Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-editing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class IbexaCustomTagEditing extends Plugin {
</button>`;

domElement.innerHTML = `
<div class="ibexa-custom-tag__header-title">${customTagConfig.label}</div>
<div class="ibexa-custom-tag__header-title" title="${customTagConfig.label}">${customTagConfig.label}</div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label should strictly speaking be escaped. If so, how do you want it escaped?
For instance, adding " or </div> in translation file will break the html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, changed title= into data-cke-tooltip-text=. Not sure if this is preferable or not

<div class="ibexa-custom-tag__header-actions">
${Object.keys(customTagConfig.attributes).length ? attributesButton : ''}
<button type="button" class="ibexa-btn ibexa-btn--ghost ibexa-btn--small ibexa-btn--no-text ibexa-btn--remove-custom-tag">
Expand Down
7 changes: 7 additions & 0 deletions src/bundle/Resources/public/scss/_custom-tag.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@
border-top-right-radius: $ibexa-border-radius;
}

&__header-title {
text-overflow: ellipsis;
white-space: nowrap;
overflow: hidden;
width: 80%;
}

&[data-ezelement='eztemplateinline'] {
padding: calculateRem(4px) calculateRem(8px);
}
Expand Down
Loading