IBX-9296: Custom CSS classes not working for "embedimage" #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dew326
approved these changes
Dec 10, 2024
lucasOsti
approved these changes
Dec 11, 2024
bozatko
approved these changes
Dec 13, 2024
tischsoic
approved these changes
Dec 13, 2024
|
I have noticed differences in display for testing on PR vs testing with patch as below:
|
barbaragr
requested changes
Dec 18, 2024
barbaragr
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Custom class was there under
custom-classesattribute, but it was in form ofibexa-embed-type-image {custom_class}socleanClassesmethod was removing this whole attribute (asibexa-embed-type-imagewasn't in custom classes options config and all custom-classes had to be matched)I've added to config info about this component class and before any checks I remove it from attribute.
Also, I have to remove it later manually from model attributes, as otherwise
ibexa-embed-type-imageis duplicated - probably comes from container declaration and from custom-classes, co one of these origins had to be cleared.For QA:
Documentation: