Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ibexa/rector] Backported Ibexa Rector recipe to 4.6 #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jan 28, 2025

🎫 Issue n/a

Description:

This PR backports 5.0 configuration to 4.6. 4.6 branch is already available for ibexa/rector package.
Ibexa 5.0 set contains deprecations that should be removed in 4.6 anyway.

There might be some minor differences (like we deprecated something in 5.0 only). We could approach that in several ways:

  • Keep different contents of 5.0 set list between 4.6 and 5.0 branches in ibexa/rector package,
  • Keep a copy of the 5.0 set as the 4.6 set with changes,
  • Ensure all 5.0 rules are executable on 4.6.

WDYT?

Edit: after today's dry run for the presentation the conclusion was that having IBEXA_46 set would look less confusing in case of 4.6.

Note: ideally we take conclusions as follow up changes, because I need this recipe for Ibexa Summit this week.

Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-152

before executing the recipes.

@alongosz alongosz requested a review from a team January 28, 2025 11:00
@alongosz alongosz changed the title [ibexa/rector] Backported Ibexa Rector to 4.6 [ibexa/rector] Backported Ibexa Rector recipe to 4.6 Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant