EZP-32460: Move problematic call to SystemInfoCollector::collect to outside of constructor #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
changed the title
|
Hi! Thank you for great contribution. Could you please change the target branch to 4.6 and rebase the PR ? If you are not able to do so, please let me know and I will take over PR. |
…e of constructor
|
Rebased it @adamwojs . Thanks for having a look! |
adamwojs
approved these changes
Feb 1, 2025
|
|
Thank you for contribution @ryanolee! We will include patch as part of the 4.6.17 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes problematic call to FS bound function. This should globally cut ibexa platform request processing times by ~ 7 MS depending on the size of the composer.lock file and the storage medium being queried.
See https://issues.ibexa.co/browse/EZP-32460 for more details
How
By moving the actual parsing of the composer.lock file to when it is required by calls to
IbexaSystemInfoCollector::collectinstead of the__constructmethod where it is seemingly invoked most requestsWhy
Over a large number of requests, especially many short ones this particular call can result in noticeable performance degradation compounded in N+1 scenarios where this code path can be hit many times over the course of a number of requests or longer term use of the admin UI cc @ibexa/php-dev