Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cursorlineopt=both in the builtin previewer #61

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Set cursorlineopt=both in the builtin previewer #61

merged 1 commit into from
Aug 30, 2021

Conversation

fsouza
Copy link
Contributor

@fsouza fsouza commented Aug 29, 2021

This way, if the user has defined cursorlineopt=number elsewhere, we
override it to behave as intended.

This way, if the user has defined cursorlineopt=number elsewhere, we
override it to behave as intended.
fsouza added a commit to fsouza/dotfiles that referenced this pull request Aug 29, 2021
Use the deprecated window_on_create for now. Once ibhagwan/fzf-lua#61 is
merged I can remove that call.
@ibhagwan
Copy link
Owner

Tysm for this I can already see myself struggling for maybe a couple of hours struggling with an issue why someone can’t see the cursor line, you just saved me those hours :)

@ibhagwan
Copy link
Owner

Ok, I just tested I can't merge this as is, this option doesn't exist in the 0.5 release, I can only find it in the nightly version, I have to find a way to first check if the option exists before trying to set it will spawn the error:

Error executing vim.schedule lua callback:
...ack/packer/opt/fzf-lua/lua/fzf-lua/previewer/builtin.lua:112: Invalid option name: 'cursorlineopt'

@ibhagwan ibhagwan merged commit 941064e into ibhagwan:main Aug 30, 2021
@ibhagwan
Copy link
Owner

Merged, solved this by using vim.fn.exists(&option) to verify the option exists before setting it.

@fsouza fsouza deleted the cursorlineopt=both-in-preview branch August 30, 2021 05:48
@fsouza
Copy link
Contributor Author

fsouza commented Aug 30, 2021

@ibhagwan ohhh my bad, I didn't realize this was a 0.6+ thing. Thanks for fixing it!

litao91 pushed a commit to litao91/fzf-lua that referenced this pull request Sep 21, 2023
docs: update customize-quickfix-window link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants