Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(template): add more details #153

Merged
merged 1 commit into from
Jan 17, 2017
Merged

refactor(template): add more details #153

merged 1 commit into from
Jan 17, 2017

Conversation

pidupuis
Copy link
Collaborator

@pidupuis pidupuis commented Jan 17, 2017

No verification steps.

@ghost
Copy link

ghost commented Jan 17, 2017

Your pull request doesn't follow our guidelines. Please fix the following:

  • Pull request description must include verification steps (?)
  • Pull request description cannot be empty (?)
  • Pull request title must start with lowercase (?)

Click here for details.

Thank you! 🙏

This comment was made by GitMagic – Magically enforcing your contribution guidelines.

@pidupuis pidupuis changed the title Refactor(template): add more details refactor(template): add more details Jan 17, 2017
@ghost
Copy link

ghost commented Jan 17, 2017

This pull request still violates some of our guidelines:

  • Pull request description must include verification steps (?)
  • Pull request description cannot be empty (?)

Click here for details.

@ghost
Copy link

ghost commented Jan 17, 2017

Thank you, the title and description now looks good! :bowtie:

@pidupuis pidupuis merged commit a55922e into canary Jan 17, 2017
@pidupuis pidupuis deleted the refactor/template branch January 17, 2017 17:41
@iblh iblh mentioned this pull request Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant