feat(load): add a javascript load queue #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
load a javascript load queue
cubesky
force-pushed
the
feat/load_queue
branch
from
e126b1b to
4cd105e
Compare
|
Use lazyload for background image. Now, background image will be shown when the image finished download. This will avoid viewer looking for a picture is downloading in progress. |
|
顺带把图库的修复了啊🌚🌚 |
pidupuis
requested changes
Jan 20, 2017
| <% if(theme.background.bing.enable) { %> | ||
| <script type="text/javascript"> | ||
| queue.offer(function(){ | ||
| $('body').attr("data-original","https://api.i-meto.com/bing?<%= theme.background.bing.parameter %>"); |
There was a problem hiding this comment.
- Please use single quotes inside JavaScript code
- Please put a space after comma
|
|
||
|
|
||
| function offer(element) { | ||
| if(this.debug) console.log("Offered a Queued Function."); |
There was a problem hiding this comment.
- Please user single quote inside JavaScript code (change it for entire file)
- Please surround
ifstatement with brackets even for one line, and display it in several lines (change it for entire file)
| } | ||
|
|
||
| function execNext() { | ||
| var nextfunc=this.poll(); |
There was a problem hiding this comment.
- Please surround
=by space
|
|
||
| function execNext() { | ||
| var nextfunc=this.poll(); | ||
| if(nextfunc != undefined) { |
There was a problem hiding this comment.
- Please use strict equality
| @@ -84,6 +84,8 @@ | |||
| <%- css("css/style.min") %> | |||
| <%- partial("_partial/config_css") %> | |||
| <%- js("js/jquery.min") %> | |||
| <%- js("js/queue") %> | |||
There was a problem hiding this comment.
- Please use single quotes inside JavaScript code (change it for the entire stack of import)
| @@ -15,18 +15,20 @@ | |||
| <% if(theme.comment.use == "duoshuo") { %> | |||
There was a problem hiding this comment.
- Please use strict equality
- Please use single quotes in JavaScript code
|
Ok, I will fix it as soon as possible. |
|
@pidupuis I fixed it. Please review. |
pidupuis
approved these changes
Jan 21, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Description
Add a javascript load queue.
You can use
queue.offer(function(){ });to add a function to load queue and it will automatic called when document DOM finished loading.You can also use this in
head.ymlto use this queue.Now, Bing background and Comment (Disque/Duoshuo) loading using this load queue.
Verification steps
No verification steps.