Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update granite model #159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update granite model #159

wants to merge 1 commit into from

Conversation

sree24lakshmi
Copy link
Contributor

@sree24lakshmi sree24lakshmi commented Dec 13, 2024

PR Checklist

Model Interaction

  • Flexible LLM platform support The platform should be easily switchable. Use LangChain or LlamaIndex.
  • Use prompt guide corresponding to the model For example for Granite 3.x Language Models

Data

  • Example data: Follow the example data guidance.

Notebook requirements

  • Notebook outputs cleared: Ensure all notebook outputs are cleared.
  • Automated testing: Add the recipe to the automated tests as described here
  • Test in Google Colab:
    • Test that it works in Google Colab (Python 3.10.12).
    • Colab has its own package set and Python version, so ensure compatibility.
  • Test locally:
    • Ensure the code works in a fresh Python virtual environment (venv).
  • Standard access to secrets and variables Include !pip install git+https://github.com/ibm-granite-community/utils in the first code cell in order to make get_env_var available to accessing secrets and variables in the recipe.

Incoming References

  • README.md updates:
    • Add a link to the recipe in the Table of Contents (ToC).
    • Include a Colab button after that link.

GitHub

  • Commits signed: All commits must be GPG or SSH signed.
  • DCO Compliance: Developer Certificate of Origin (DCO) applies to the code, documentation, and any example data provided. Ensure commits are signed off.

@pravinkedia
Copy link

Approved

1 similar comment
@pravinkedia
Copy link

Approved

@pravinkedia pravinkedia enabled auto-merge (squash) December 13, 2024 06:11
"model_id=\"ibm-granite/granite-20b-code-instruct-8k\"\n",
" \n",
"#model_id=\"ibm-granite/granite-20b-code-instruct-8k\"\n",
"model_id=\"ibm-granite/granite-3.0-8b-instruct\"\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"model_id=\"ibm-granite/granite-3.0-8b-instruct\"\n",
"model_id=\"ibm-granite/granite-3.1-8b-instruct\"\n",

This should be granite 3.1 for tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants