Adding data prep recipes #96
Conversation
Signed-off-by: Hima Patel <[email protected]>
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "<a href=\"https://colab.research.google.com/github/IBM/data-prep-kit/blob/dev/examples/notebooks/code/sample-notebook.ipynb\">\n", |
There was a problem hiding this comment.
This cell will be pointing to the wrong place when merged in this repo, and colab buttons in the notebook is not in line with our style guide. Please drop this cell
There was a problem hiding this comment.
File path is fixed. We may not be able to drop this cell. Can you pls suggest on how you would like the colab button to be?
There was a problem hiding this comment.
Please drop the cell. Just delete it.
| "## Setup\n", | ||
| "\n", | ||
| "Install data-prep-toolkit and datasets library. This notebook requires atleast 8 cpus. \n", | ||
| "To run on google colab, it is recommended to change the runtime to TPUs to get the required number of cpus.\n" |
There was a problem hiding this comment.
Can this notebook be reworked to drop this requirement. At best, you won't get 8cpus for the testing (at least w/o some additional config, which I don't know how to do off the top of my head).
There was a problem hiding this comment.
We have updated to 4. There is guidance in the notebook to select TPUs and these nodes can be then made available via Colab.
There was a problem hiding this comment.
Not in testing though. You can only get 2 cpus for the test suite
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "from data_processing_ray.runtime.ray import RayTransformLauncher\n", |
There was a problem hiding this comment.
this line fails in testing and also fails for me when trying to run in colab
There was a problem hiding this comment.
I have been able to run it in colab post the pip installations. Please see link here https://colab.research.google.com/drive/1uxKhvPZLbSnPmAGYfQ0jnrJIiDbfeIcJ#scrollTo=NbF_Zw3KBazf
There was a problem hiding this comment.
i don't have access, but was your runtime CPU only or TPU?
Signed-off-by: Hima Patel <[email protected]>
Signed-off-by: Hima Patel <[email protected]>
|
The notebook fails on CI/CD on Can you pls suggest why replicate token is required in this notebook ? |
Signed-off-by: Hima Patel <[email protected]>
Signed-off-by: Hima Patel <[email protected]>
Signed-off-by: Hima Patel <[email protected]>
@Bytes-Explorer the replicate token is required in another notebook (./recipes/Getting_Started_with_Granite_Code.ipynb), which is being tested by the CI action. It looks like the action sets the REPLICATE_API_TOKEN from secrets, so maybe that secret hasn't been added to this repo yet? I'll defer to @rawkintrevo on that. |
|
it has been added to this Repo, but I don't think it gets picked up when making a PR from an outside repo. Ill link the conversation on slack to show them how to set this up. Also, as @fayvor said, Also note the test is testing all of the notebooks, not just the one you added. It is failling in the 'Getting Started With Granite' notebook, not yours. |
No description provided.