test: fix tls-inception

Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables. PR-URL: nodejs/node#4195 Reviewed-By: Brian White <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
ibmruntimes · Dec 10, 2015 · 86a3bd0 · 86a3bd0
1 parent 37ed05b
commit 86a3bd0
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/test/parallel/test-tls-inception.js b/test/parallel/test-tls-inception.js
@@ -12,8 +12,7 @@ var fs = require('fs');
 var path = require('path');
 var net = require('net');
 
-var options, a, b, portA, portB;
-var gotHello = false;
+var options, a, b;
 
 var body = new Buffer(4000).fill('A');
 
@@ -43,10 +42,6 @@ b = tls.createServer(options, function(socket) {
   socket.end(body);
 });
 
-process.on('exit', function() {
-  assert(gotHello);
-});
-
 a.listen(common.PORT, function() {
   b.listen(common.PORT + 1, function() {
     options = {
@@ -62,15 +57,14 @@ a.listen(common.PORT, function() {
     });
     ssl.setEncoding('utf8');
     var buf = '';
-    ssl.once('data', function(data) {
+    ssl.on('data', function(data) {
       buf += data;
-      gotHello = true;
     });
-    ssl.on('end', function() {
+    ssl.on('end', common.mustCall(function() {
       assert.equal(buf, body);
       ssl.end();
       a.close();
       b.close();
-    });
+    }));
   });
 });