Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trivial linter warnings and errors #13

Merged
merged 49 commits into from
Aug 20, 2024
Merged

Conversation

hagau
Copy link
Collaborator

@hagau hagau commented Aug 12, 2024

This fixes some of the trivial linter warnings & errors that are reported by ruff and pylint.
None of these changes are functionally relevant, no bugs have been found.
There are still quite a few warnings left, a few just require the proper configuration of ruff and pylint.

Some of the remaining warnings & errors require more invasive changes and will be addressed in separate PRs.

hagau added 30 commits August 10, 2024 01:49
import, move the registration into a dedicated function
Only the debugging helper need to be imported and made available by
default.
@hagau hagau marked this pull request as draft August 12, 2024 12:44
hagau added 19 commits August 12, 2024 17:20
This is likely an unattentive copy and paste error from the pyyaml
documentation.
This is likely an unattentive copy and paste error from the pyyaml
documentation.
This is likely an unattentive copy and paste error from the pyyaml
documentation.
This is likely an unattentive copy and paste error from the pyyaml
documentation.
This is likely an unattentive copy and paste error from the pyyaml
documentation.
This is likely an unattentive copy and paste error from the pyyaml
documentation.
variable `debug` and the its associated `debug_print` function
@hagau hagau marked this pull request as ready for review August 20, 2024 14:59
@hagau hagau merged commit ef86a84 into main Aug 20, 2024
1 check passed
@hagau
Copy link
Collaborator Author

hagau commented Aug 20, 2024

I've merged this now, even though there are still more things the linter complains about. Since I'm working on two other PRs at the moment, I want to minimize the divergence between them, thus the remaining linter issues will be resolved after the open PRs have been completed.

@hagau hagau deleted the fix_trivial_linter_errors branch August 20, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant