Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catchall without prefix slash #43

Merged

Conversation

LukeMathWalker
Copy link
Contributor

I took a stab at implementing #42, with the exception of the standalone catch-all (i.e. *all).

@ibraheemdev
Copy link
Owner

I don't think #42 actually proposed to allow this, it was mainly concerned with leading catch-alls. However, we allow this for regular parameters, so I don't see a problem with allowing it for wildcards too. In general, / shouldn't really need to be specially recognized by the router, especially with the syntax change proposal in #35 - this removes one of the last cased where it is.

Thanks!

@ibraheemdev ibraheemdev merged commit fa80427 into ibraheemdev:master Nov 2, 2023
5 checks passed
@LukeMathWalker
Copy link
Contributor Author

I had indeed misunderstood #42 😅 But glad that you found this useful anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants